Closed EdCaunt closed 2 months ago
So you still needs the subs eventhough the parent is yi
?
condition = Lt(sdf.subs(y, yi), 1)
would maybe make more sense.
Is there a test/example for it?
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.44%. Comparing base (
42cce7e
) to head (5fac196
). Report is 5 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
So you still needs the subs eventhough the parent is
yi
?
condition = Lt(sdf.subs(y, yi), 1)
would maybe make more sense.Is there a test/example for it?
Yeah, you still need the .subs
. A test needs to be added, it would probably also be a good idea to add an example
Closed as replicates a fix already in #2050
Tweak dimension extraction from conditions so that ConditionalDimensions can have SubDimension parents.
Now you can do
and the
ConditionalDimension
will be nested inside theSubDimension
in the generated loops.