search

devitocodes / devito

DSL and compiler framework for automated finite-differences and stencil computation
http://www.devitoproject.org
MIT License
536 stars 221 forks source link

api: cleanup FD tools and support zeroth order derivative #2368

Closed mloubout closed 1 month ago

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 96.52174% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 86.75%. Comparing base (a400992) to head (b10ef96).

Files Patch % Lines
devito/types/basic.py 75.00% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2368 +/- ## ======================================= Coverage 86.75% 86.75% ======================================= Files 233 233 Lines 43720 43727 +7 Branches 8078 8072 -6 ======================================= + Hits 37929 37937 +8 Misses 5080 5080 + Partials 711 710 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

review-notebook-app[bot] commented 2 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jkwashbourne-oss commented 2 months ago

Great work! What about a unit test interpolating an analytic function like a sin or cos?

mloubout commented 2 months ago

What about a unit test interpolating an analytic function like a sin or cos?

There is a unit test checking coefficient correctness.