Closed EdCaunt closed 1 week ago
Attention: Patch coverage is 97.03704%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 87.26%. Comparing base (
2f4f80f
) to head (6e7c017
). Report is 21 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
devito/ir/equations/algorithms.py | 81.81% | 1 Missing and 1 partial :warning: |
devito/types/dimension.py | 97.82% | 1 Missing and 1 partial :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Merged, thanks
Fixes issues with standalone use of
SubDimension.symbolic_min
orSubDimension.symbolic_max
in an operator. Previously variants onwould suffer from two issues:
ix.symbolic_max
) would not be concretised fromx_ltkn
tox_ltkn0
_arg_values
unless the user explicitly passed it to the operator (and even then, it would not be adjusted to reflect any MPI decomposition)These are rectified by this PR.