devitocodes / devito

DSL and compiler framework for automated finite-differences and stencil computation
http://www.devitoproject.org
MIT License
565 stars 229 forks source link

compiler: Fixup minor cire-rotate bug #2472

Closed FabioLuporini closed 1 month ago

FabioLuporini commented 1 month ago

WIP: MFE still pending (and therefore PR not ready for merge yet), but the fix should be OK

also improving code gen aesthetics

from

         for (int x = x0_blk0, xs = 0, xr0 = (xs)%(3), xr1 = (xs + 2)%(3), xii0 = -1; x <= MIN(x_M, x0_blk0 + x0_blk0_size - 1); x += 1, xs += 1, xr0 = (xs)%(3), xr1 = (xs + 2)%(3), xii0 = 1)
          {

to

          for (int x = x0_blk0, xs = 0, xii0 = -1; x <= MIN(x_M, x0_blk0 + x0_blk0_size - 1); x += 1, xs += 1, xii0 = 1)
          {
            int xr0 = (xs)%(3);
            int xr1 = (xs + 2)%(3);
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.19%. Comparing base (154140f) to head (7af2372). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2472 +/- ## ========================================== + Coverage 87.18% 87.19% +0.01% ========================================== Files 238 238 Lines 45141 45185 +44 Branches 4005 4008 +3 ========================================== + Hits 39356 39400 +44 Misses 5104 5104 Partials 681 681 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

review-notebook-app[bot] commented 1 month ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB