Open EdCaunt opened 1 week ago
I personally wouldn't. Flake8 is really not adapted to notebooks, where readable and potentially longer lines are preferred.
We could always set a custom rule to ignore "line too long"
Looking at it, there are only about 5 "Line too long" warnings in the whole output, and most are only 5 or so characters over.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.26%. Comparing base (
2f18ab8
) to head (be6715a
). Report is 5 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
This diff is way too big for just a few line change.
Yeah, I messed up adding the changes in one of the notebooks somehow. Will fix in due course
Also those depa should be in requirements-testing.txt not hardcoded in the yaml
I was just going off how the Flake8 workflow already works, can change this
@ggorman pointed out that you can now Flake8 lint Jupyter Notebooks. We should probably do this.