devitocodes / notebooks

BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

Speed up analytica solution by using `scipy.special.hankel2` #3

Closed mlange05 closed 8 years ago

mlange05 commented 8 years ago

This merge speeds up the computation of the analytic solution by using the pre-compiled scipy version of the hankel2 function. @mloubout, can you please verify that the outcome is still correct?

mloubout commented 8 years ago

It creates an error TypeError: ufunc 'hankel2' not supported for the input types, and the inputs could not be safely coerced to any supported types according to the casting rule ''safe''

The inverse fourier transform is also quite expensive, and this only would be run once for testing, so I don;t think speed matter that much for this one

mloubout commented 8 years ago

My bad, indeed much faster, thank you @mlange05

There is some time wrap-around I need to fix however