search

devjainofficial / Weather-app

A simple and user-friendly weather application which lets the users know the temperature of any location across the globe and also various parameters. This application has been built using HTML, CSS, JavaScript and weather API.
https://globalweatherappdev.vercel.app/
MIT License
7 stars 21 forks source link

Bug with the footer. #31

Closed therahulchaurasia closed 11 months ago

therahulchaurasia commented 11 months ago

Hey @devjainofficial, I just saw the newly added footer and I think it's awesome and it suits the project very well. However, just as I was trying to run the code I saw a few issues that were introduced with this feature. Firstly, I would like to point the error that occurs when you try to run the new code. image This occurs because the old copyright has been commented in the index file we try to access it in js. Fix: It will be a simple fix and I can do it for you.

Another issue The footer does not appear at the bottom of the content, instead it takes an entire screens height and calculates the bottom. image Fix: I'll need to change the CSS for the footer and it will work fine.

therahulchaurasia commented 11 months ago

Can you please assign this issue to me so I can work on fixing the issues mentioned above.

devjainofficial commented 11 months ago

Thankyou for addressing this bug, please do it

therahulchaurasia commented 11 months ago

Hey @devjainofficial I think this issue can be closed because my PR fixes the above issue and I have attached the screenshot for the same.

devjainofficial commented 11 months ago

sure