search

devjainofficial / Weather-app

A simple and user-friendly weather application which lets the users know the temperature of any location across the globe and also various parameters. This application has been built using HTML, CSS, JavaScript and weather API.
https://globalweatherappdev.vercel.app/
MIT License
7 stars 21 forks source link

Footer fixed #32

Closed therahulchaurasia closed 11 months ago

therahulchaurasia commented 11 months ago

My PR closes the issue #31 Hey, I worked on fixing the error and styling the footer as mentioned in the issue. I am attaching screenshots for both. You can check them and let me know if you need some other changes. The error with the old copyright footer has been fixed. image

The footer now appears below the content. image

therahulchaurasia commented 11 months ago

I cannot understand the issue with restyled. It says the check has failed but when you open the details it shows success. Please merge my pr with the label hacktoberfest-accepted if everything seems fine to you. Let me know if you need some changes.

devjainofficial commented 11 months ago

Thank you for your contribution.

devjainofficial commented 11 months ago

image After merging your pull request still has an icon issue. I you want to continue this progress, create one more pull request with icon correction..

therahulchaurasia commented 11 months ago

Hey @devjainofficial Can you attach the screenshot of the console so I can view the error? As soon as you mentioned the above issue I synced the fork with your repository and everything works fine on the dev server. image

devjainofficial commented 11 months ago

Issue is resolved. Thanks for your support.

therahulchaurasia commented 11 months ago

Welcome, and I enjoyed working on your repo. 🚀