devjainofficial / Weather-app

A simple and user-friendly weather application which lets the users know the temperature of any location across the globe and also various parameters. This application has been built using HTML, CSS, JavaScript and weather API.
https://globalweatherappdev.vercel.app/
MIT License
7 stars 21 forks source link

aqi is visible now #36

Closed LalitDeore closed 11 months ago

LalitDeore commented 11 months ago

aqi

Aqi is visible now. Issue was that aqi was being updated before asynchronous request made.

vercel[bot] commented 11 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
weather-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2023 3:41am
devjainofficial commented 11 months ago

It shows 390 for all the cities.

LalitDeore commented 11 months ago

airquality

I have seen response of an air quality object, but there is no data on air quality from the API. That's why there is NaN while getting that data dynamicaly from the API.

LalitDeore commented 11 months ago

Hey @devjainofficial Can you merge this repo if possible? could help me with the hacktoberfest.

devjainofficial commented 11 months ago

Send me the screenshot of the whole running website

devjainofficial commented 11 months ago

Actually, while I am running your code some of the elements got misplaced. check out those fix them, then I will merge your request

LalitDeore commented 11 months ago

Hey @devjainofficial i have commit changes a aqi-updated nd fix element misplace code.

devjainofficial commented 11 months ago

Sync your forked repo, you are One merge behind

devjainofficial commented 11 months ago

Do one more thing your code is very unreadable. Make sure to use linting

LalitDeore commented 11 months ago

check my latest commit I have added same code as yours on your github repo. I have comment one line which changes the dynamic updation of the aqi.

LalitDeore commented 11 months ago

Thank you @devjainofficial you can close this pr and issue.

devjainofficial commented 11 months ago

Please sync your repo

LalitDeore commented 11 months ago

Just sync my repo