devkennyy / rungeon

🏃‍♂️Open source, puzzle based adventure game in your browser
https://rungeon.live/
GNU General Public License v3.0
17 stars 21 forks source link

RGB theme is no longer RGB #147

Closed devkennyy closed 2 years ago

devkennyy commented 2 years ago

The RGB theme doesn't actually make any of the stage content RGB. The selectors are there but there's obviously a problem.

#index.theme-rgb .nav-link,
#index.theme-rgb .stage .icon,
#index.theme-rgb .doors i,
#index.theme-rgb .links i,
#index.theme-rgb #themePopup,
#index.theme-rgb #themePopup #closeButton {
  animation: rgb 5s linear infinite !important;
}
Shabbyconnor commented 2 years ago

It appears that the CSS applied to the "stage" class is overwriting the RGB. Turn it off and we get the RGB. However, the CSS is reasonable for applying the rest of the themes so I'll have to figure something out

Shabbyconnor commented 2 years ago

Kay. I've got a fix. Remind me what RGB is supposed to look like. Does the text need to be RGB too? How about the continue button?

devkennyy commented 2 years ago

There's an RGB animation, you just need to apply it to the stage icon and whatever else looks good (maybe the navbar icons?).

Shabbyconnor commented 2 years ago

Originally it looked like this:

Screen Shot 2022-07-28 at 4 10 33 PM

I can make it look like that, or I can go more intense and make it look like this:

Screen Shot 2022-07-28 at 4 17 36 PM

What do you think?

devkennyy commented 2 years ago

This is definitely nicer, if you want rgb, you're getting rgb :trollface:

gruelingpine185 commented 2 years ago

@Shabbyconnor Was it intentional to have the elements and icons changing colors unsynchronized?

Shabbyconnor commented 2 years ago

No, but I'm not sure of a way to sync them up. The problem is the animation starts at the beginning when a new element is created. Some elements on the page never change like the navbar. But some like the text and icon change every time the stage switches. Causing the RGB animation to reset, and become out of sync

gruelingpine185 commented 2 years ago

Oh. So since only the icon and the prompt changes every stage switch, could it be possible to make a function that captures stage switches and removes and replaces the rgb animation? The transition between stages might be a bit rough, but at least the colors are synced

Shabbyconnor commented 2 years ago

Yeah. You'd have to replace the animation for each element though.

Shabbyconnor commented 2 years ago

@Shabbyconnor Was it intentional to have the elements and icons changing colors unsynchronized?

Fixed by #151