As you've possibly noticed from the latest release build, the version string is a somewhat confusing 2.4.2-v2.4.1-4-gc63d531. This is pulled from a git describe --dirty --always in the Makefile. git describe will by default only check annotated tags. There's a long explanation of this behavior on StackOverflow for anybody who's interested.
The latest tag as of this PR is v2.4.2 but the latest annotated tag is v2.4.1. As such, git describe is picking up the wrong tag when building non-release versions.
For reference, here's me just running git describe from terminal, with and without the --tags argument:
Adding --tags to the Makefile allows the correct tag to be picked up, whether or not it's an annotated tag. An alternative to accepting this PR would be to exclusively use annotated tags in future, so that they are always picked up by git describe.
As you've possibly noticed from the latest release build, the version string is a somewhat confusing
2.4.2-v2.4.1-4-gc63d531. This is pulled from agit describe --dirty --alwaysin the Makefile.git describewill by default only check annotated tags. There's a long explanation of this behavior on StackOverflow for anybody who's interested.The latest tag as of this PR is
v2.4.2but the latest annotated tag isv2.4.1. As such,git describeis picking up the wrong tag when building non-release versions.For reference, here's me just running
git describefrom terminal, with and without the--tagsargument:Adding
--tagsto the Makefile allows the correct tag to be picked up, whether or not it's an annotated tag. An alternative to accepting this PR would be to exclusively use annotated tags in future, so that they are always picked up bygit describe.