devkitPro / SDL

Simple Directmedia Layer
https://libsdl.org
zlib License
15 stars 12 forks source link

Updated the switch portlib to v2.28.1 #24

Closed giroletm closed 1 year ago

giroletm commented 1 year ago

Ported all of the patches from the switch portlib to the latest SDL2 release (because the current version is from 2020).

I have included ideas to avoid loosing commit history in a pull request I made on the pacman-package repo (because I sent my edits there first): https://github.com/devkitPro/pacman-packages/pull/305

I can provide a build if needed, compiled on my computer with the latest devkitPro at the time of writing. Tested it both on Ryujinx and on my own Nintendo Switch.

Included all contributors in the commit message to avoid their names being lost due to the update if merged.

i'd advise pulling main from upstream as well (with tags) to have the most recent release tags and have an updated main to be consistent with this update

WinterMute commented 1 year ago

This PR contains rather a lot of upstream SDL2. The first step to producing a patchset needs to be rebasing the current patches against newer upstream then fixing issues that arise from there.

giroletm commented 1 year ago

I did include upstream SDL2 commits to have them in the history, rather than a big commit with all changes SDL2 has received since the current version. Not sure what's the best way to do this. Either way, feel free to build my repo, and see it works, no issues. Please guide me to how making this PR better, I'm not sure I understand what you mean by "rebasing the current patches against newer upstream then fixing issues".