devkitPro / docker

Dockerfiles for https://hub.docker.com/u/devkitpro/
GNU General Public License v3.0
58 stars 28 forks source link

Unable to build Atmosphere, module lz4 missing from python #32

Closed borntohonk closed 1 month ago

borntohonk commented 1 month ago

File "/build/Atmosphere/exosphere/program/split_program.py", line 2, in import sys, lz4 ImportError: No module named lz4

kindly add https://packages.debian.org/bullseye/amd64/python/python3-lz4 to the base container.

Thank you for addressing the lack of hactool in previous issue @WinterMute

borntohonk commented 1 month ago

also

sudo docker run --name devkitpro \
 --rm \
 --volume $PWD/.:/out \
 devkitpro/devkita64:latest /bin/bash -c \
 "which python && \
 python --version"

returns

/usr/bin/python Python 2.7.18

please also add https://packages.debian.org/bullseye/python3 https://packages.debian.org/bullseye/python-is-python3

and remove: https://packages.debian.org/bullseye/python2 (symlinked just python in debian bullseye which you base https://github.com/devkitPro/docker/blob/master/toolchain-base/Dockerfile#L13 out of

in bookworm and later python is by default python3

Adding python3, python3-lz4, would turn this toolchain into one fully capable of compiling atmosphere.

(im surprised no one has pointed this out before)

WinterMute commented 1 month ago

I know @Sciresm doesn't want want normal users using random commits so building atmosphere with docker isn't something we support right now. I would recommend speaking to him before you embark on any kind of automated build and release for his project.

https://github.com/Atmosphere-NX/Atmosphere/pull/2163#issuecomment-1606747510

borntohonk commented 1 month ago

So I in other words have to maintain my own container, disappointing news. I understand