search

devkitPro / gba-examples

92 stars 22 forks source link

Is there a specific reason why -mcpu definition is set to CFLAGS instead of ARCH? #5

Open FluBBaOfWard opened 2 years ago

FluBBaOfWard commented 2 years ago 
ARCH    :=  -mthumb -mthumb-interwork

CFLAGS  :=  -g -Wall -O2\
        -mcpu=arm7tdmi -mtune=arm7tdmi\
        $(ARCH)

I can make a pull request for all makefiles if it's ok.

fincs commented 2 years ago

I'd kindly like to point out that you're looking at probably one of the oldest collections of code produced by devkitPro. There have been a good number of lessons learned over the past decades, and the exact details and rationale for certain things are not always recoverable, especially the farther you go back in time.

A more appropiate ARCH setting for the GBA that follows our latest practices is probably -march=armv4t -mtune=arm7tdmi -mthumb -mthumb-interwork - in fact, that's what the GBA support recently added to devkitPro CMake uses.

FluBBaOfWard commented 2 years ago

So should I do a PR?