search

devkitPro / installer

383 stars 40 forks source link

Allow silent uninstaller #24

Closed Crayon2000 closed 4 years ago

Crayon2000 commented 4 years ago

This PR will allow using a silent uninstaller (no dialog boxes).

In a MessageBox, the /SD parameter with a value will be used to specify the option that will be used when the uninstaller is silent. The default options in the message boxes is to uninstall devkitPro.

How to run the silent mode with NSIS:

powershell -command start-process C:\devkitPro\uninst.exe -ArgumentList '/S' -Wait

More info at https://nsis.sourceforge.io/Docs/Chapter4.html#silent

My next step is to be able to use the silent installer, but I'm having some problems. So this will be in another PR if I'm able to fix my issues.

WinterMute commented 4 years ago

Sorry. This installer is probably not going to be maintained for much longer. I won't be accepting PRs here.

I would also appreciate it a great deal if you weren't touching any of the installation infrastructure without first contacting me privately.

Crayon2000 commented 4 years ago

@WinterMute, the main reason why I wanted to touch the installation infrastructure was in fact so people could use the official devkitPro installer. Maybe I'm paranoid, but by reading the second paragraph of your comment it seems I did something bad? Maybe adding some stuff to the README.md file would have helped me do the proper steps!

I normally use the Linux Debian installer to do my CI on Linux. I thought it would be cool to do the same thing on Windows. I would never package and distribute my own copy of devkitPro. This is why I'm using the official repository to propose changes. I understand the reason why the PR is not accepted. I will delete my fork and forget about my ideas for the NSIS installer.

On Windows I use the official Docker image for devkitPPC or WSL2 for programming so I don't really care about this installer. I just though it would have been useful for other developers.

I have been using mostly devkitPPC for 12 years and I trust your decisions to create the perfect homebrew development environment.

WinterMute commented 4 years ago

You shouldn't be using the installer to do CI. You should be using the docker images we provide instead of hammering the package server. That's primarily what they're there for. Had you asked me before doing the PR I'd have told you that.

Current private contact methods are pm through forum, twitter dm & email.

The NSIS installer is just old in the tooth and doesn't really serve users that well any more. It will get replaced soon I hope.