[MAJOR] Failed msys2 installation empties "path" env variable.

PabloMK7 commented 6 years ago

Title describes the error pretty much. Trying to use the release 3.0.2 set my path env variable to an empty string. This is a major bug for obvius reasons, the user will have to manually add the path entries back.

How I got the error:

Install devkitPro toolchains with the installer normally until it says "Completed!" without clicking next and leave it open.
Uninstall devkitPro toolchains using the unistaller.
Click next and finish in the still open Updater.
Reinstall devkitPro toolchains.

(NOTE: I already had a msys2 installation in my computer, no idea if it has anything to do.)

Results: https://cdn.discordapp.com/attachments/302856274872369152/452122656389726239/unknown.png https://cdn.discordapp.com/attachments/302856274872369152/452123450111295489/unknown.png

WinterMute commented 6 years ago

Apologies. I have a fresh windows install and neglected to replace the standard NSIS compiler with the large strings version.

https://github.com/devkitPro/installer/releases/tag/v3.0.3 should fix this. I've also added checks to the uninstall section for attempts to write blank path.

PabloMK7 commented 6 years ago

Looks like avast is reporting the new installer as being a virus. Probably a false positive. https://www.virustotal.com/es/file/038a99dc84f1ca0b52e9e0e074a94a3b0672e6d7bf0988563f0ab0812dcbb38d/analysis/1528043191/

WinterMute commented 6 years ago

Hopefully sorted.

avast-whitelisted

Did 3.0.3 sort your PATH issue ok?

PabloMK7 commented 6 years ago

Yes, tried to reproduce the bug and it didn't happen again. Thanks!

devkitPro / installer

[MAJOR] Failed msys2 installation empties "path" env variable. #8