search

devkitPro / libgba

C Library for Nintendo GBA
http://devkitpro.org/viewforum.php?f=5
Other
189 stars 26 forks source link

Remove unnecessary comma in BG_CTRL_BITS enum #13

Closed rawr51919 closed 2 years ago

rawr51919 commented 2 years ago

Certain projects, like the decompilation of the ancient homebrew Pikachu ga Pokeboru o Aishimasu (ピカチュウがポケボルをアイします, Pikachu Loves Poké Balls) (https://github.com/easyaspi314/pikaaishimasu), cause warnings to be emitted when this comma is in place. Removing it fixes this warning.

fincs commented 2 years ago

Which warning does this PR exactly solve? This, as far as I can tell, is just a minor stylistic change that should not make any difference in the compiler's internal syntax tree.

rawr51919 commented 2 years ago

Which warning does this PR exactly solve? This, as far as I can tell, is just a minor stylistic change that should not make any difference in the compiler's internal syntax tree.

In that decomp, it fixes a warning that is shown as superfluous ',' in enum declaration near the end of the build. Every other enum in this file has no comma at the last entry in them (see enums LCDC_BITS and LCDC_IRQ)

rawr51919 commented 2 years ago

It could be argued that an alternate title for this PR is 'keep enums in gba_video.h to the same coding style', some projects like the decomp above would appreciate this