search

devkitPro / opengx

OpenGL-like wrapper for Nintendo Wii/GameCube
19 stars 2 forks source link

Selection mode #40

Closed mardy closed 5 months ago

mardy commented 5 months ago

As usual, better review commit by commit.

davidgfnet commented 5 months ago

Was not even aware of this ancient GL API :D (Nor the fact that the GX hardware has some limited support for it). BTW GX_ReadBoundingBox seems to have an "error" factor due to the way it internally works:

Since the hardware can only test the bounding box in quads (2x2 pixel blocks), the result of this function may contain error of plus or minus 1 pixel. Also because of this, left and top are always even-numbered and right and bottom are always odd-numbered.

Perhaps worth mentioning in a comment or something :D

LGTM otherwise!

mardy commented 5 months ago

Perhaps worth mentioning in a comment or something :D

Added!