devkitPro / pacman-packages

https://devkitpro.org
131 stars 104 forks source link

switch-ntfs-3g: install config.h #347

Closed DarkMatterCore closed 6 months ago

WinterMute commented 6 months ago

That's really odd. You'd think make install would take care of this.

While digging around upstream issues I found this which amused me https://github.com/tuxera/ntfs-3g/issues/80#issuecomment-1860861654

DarkMatterCore commented 6 months ago

It's strange, yeah. It's been a good three years or so since I last messed with the NTFS-3G portlib (besides keeping it up to date), so I didn't really remember why we implemented those seemingly weird changes to both the PKGBUILD script and the diff patch. I guess we've got our answer.

In any case, thanks again!

WinterMute commented 6 months ago

In any case, thanks again!

No worries.

I made another couple of tweaks to use the official release tarball which avoids needing the autogen & used sed to get rid of install-exec-hook instead of patching Makefile.am. PR'd the fixes upstream @ https://github.com/tuxera/ntfs-3g/pull/105 so maybe that'll get merged for next release.