search

devkitPro / tex3ds

3DS Texture Conversion
GNU General Public License v3.0
38 stars 10 forks source link

Use foreign configuration instead of touching unused files #18

Closed oreo639 closed 5 years ago

oreo639 commented 5 years ago

Makes having an output path optional and fixes libmagick++ dependency checking. Also, is there any reason for doing touch AUTHORS ChangeLog NEWS README over just doing AM_INIT_AUTOMAKE([foreign])

This pr is for feature/mkbcfnt, not master. If you would like me to make any changes, or make a separate pr for some of the changes to be commited to master, just let me know. I assume that feature/mkbcfnt will be merged with master, so it shouldn't be an issue to commit all these to that branch.

mtheall commented 5 years ago

Makes having an output path optional

I don't like this idea. Your makefile rules should be able to do the name replacement just fine.

fixes libmagick++ dependency checking

This should work with IM7, although I haven't specifically tested it.

Also, is there any reason for doing touch AUTHORS ChangeLog NEWS README over just doing AM_INIT_AUTOMAKE([foreign])

Because I don't know how to use autotools. It's a miracle anything works at all.

oreo639 commented 5 years ago

I don't like this idea. Your makefile rules should be able to do the name replacement just fine.

Ok, thank you for letting me know.

should work with IM7, although I haven't specifically tested it.

My bad, I didn't notice magick_compat in this version.

Anyway, I reverted the offending commit.

WinterMute commented 5 years ago

good stuff, thanks @Oreo639

oreo639 commented 5 years ago

Btw, I spoke too soon. `` source/bcfnt.cpp:54:32: error: conversion from 'MagickCore::Quantum' {aka 'float'} to non-scalar type 'PixelPacket' requested PixelPacket p = cache.get(x, y, 8, 8);


source/bcfnt.cpp: In constructor 'bcfnt::BCFNT::BCFNT(FT_Face)':
source/bcfnt.cpp:217:32: error: conversion from 'MagickCore::Quantum*' {aka 'float*'} to non-scalar type 'PixelPacket' requested
       PixelPacket p = cache.get(sheetX, sheetY, 24, 30);``
This issue needs to be fixed for it to compile with imagemagick7.
WinterMute commented 5 years ago

Yeah, still needs some massaging & @mtheall snuck in some C++14.

We did have the same issue with tex3ds, I think it might be header order, not 100% sure offhand.