search

devkral / lightsonplus

fork from lightsOn
39 stars 16 forks source link

Missing '-d' argument & some minor fixes #19

Closed ghost closed 6 years ago

ghost commented 6 years ago
  1. Running ./lightson+.sh 120 yields Ivalid argument. See -h, --help for more information. This is due to the missing -d parameter, which is required if the user wants to set the delay time.
  2. Typo: Ivalid
  3. The script shouldn't need the .sh extension. According to Google Shell Style Guide: "Executables should have no extension (strongly preferred) or a .sh extension. Libraries must have a .sh extension and should not be executable." Removing the .sh extension will make filenames look cleaner while still functioning normally as executables. Anyway, this comes down to personal preferences though.
ghost commented 6 years ago

And also, as my OCD is tingling already, line 19: will Check should be --> will check (notice the letter C becomes lowercase).

.sh extension should be removed for lightson+cmd.sh too.