Jakarta namespace update

devlauer / plantuml-generator

utility and maven plugin project for generating plantuml class diagrams and sequence diagrams out of java classes

https://devlauer.github.io/plantuml-generator/plantuml-generator/latest/index.html

Apache License 2.0

87 stars 27 forks source link

Jakarta namespace update #126

Closed Maxouwell closed 4 weeks ago

Maxouwell commented 10 months ago

Hello,

Would you take a PR on a jakarta update for addJPAAnnotations and addJavaxAnnotations ?

I'm thinkinf of

For addJPAAnnotations, simply adding jakarta.* annotation search in JPAAnalyzerHelper and allowing both on the doc
For addJavaxAnnotations, doing one or more of :
- Renaming the parameter to addJavaBeanAnnotations (breaking change, but I may be the only one using it)
- Renaming the docs to addJavaBeanAnnotations
- Adding jakarta.* annotation search in JavaxValidationAnalyzerHelper

What do you think ? Regards

devlauer commented 10 months ago

An additional consideration of the jakarta namespace makes sense, because sooner or later all users switch to it. That you rename in this case the method addJavaxAnnotations as well as the associated internal methods and the class JavaxValidationAnalyzerHelper likewise. Regarding the breaking change I would like to see a hint in the documentation, so that other potential users know what to change to. In this respect I would adopt the PR.

Maxouwell commented 9 months ago

Hello !

Not a lot of time on my hand lately, I made a PR for the (easy) JPA Annotation part : https://github.com/devlauer/plantuml-generator/pull/140

Let me know !

devlauer commented 8 months ago

Sorry for the delayed answer! Thanks you very much for your contribution! I've merged your PR and created a new version (2.4.0), which should be available in the next hours.

Maxouwell commented 2 months ago

Well it's was not that easy since I botched a part. Fixed in #205

Maxouwell commented 2 months ago

And as I was on it, #206 for adding the jakarta Validation part

devlauer commented 4 weeks ago

@Maxouwell : Thank you very much for your contribution! And I am really sorry for the long wait! I released both pull requests as part of version 3.0.1. This version should be available within the next hours.