devlint / gridlex

Just a CSS Flexbox Grid System
http://gridlex.devlint.fr
MIT License
1.38k stars 145 forks source link

Attribute Selectors #1

Closed ctidd closed 8 years ago

ctidd commented 8 years ago

[attr*=value] selectors for class names in this context are likely to have unintended consequences, particularly with such short class values and no namespacing. (Imagine classes such as collapse or color.)

Sticking with the approach of loose-matching selectors, the col selector looks like it could be more safely expressed as .col, [class*="col-"] without breaking compatibility. What do you think of this?

devlint commented 8 years ago

You're right! I'm just working on it to protect that. Thank you

devlint commented 8 years ago

Fixed, thx for your comment!

ctidd commented 8 years ago

Awesome, thanks!