devlocalhost / pyspodl

pyspodl - a spotify downloader using librespot
MIT License
10 stars 2 forks source link

set_metadata function randomly breaking #6

Closed devlocalhost closed 1 year ago

devlocalhost commented 2 years ago

mutagen.oggvorbis.OggVorbisHeaderError: unable to read full header; got b'\x00'

In a email I sent,

"And yes, I'm aware of that issue. The set_metadata function is kinda broken. It works, but also breaks, and I am not really sure why. I suspect it might be because of the extension.

The library I'm using to download the track, librespot, downloads the track as a OGG Vorbis file (if you use mpv, press "i"), not as a mp3 file. The extension of the track should not be .mp3, but .ogg instead

The reason I am not using the ogg extension, is because I am not sure if media players are going to play ogg files (well, they should), since mp3 is more common than ogg

A fix to this issue is converting the ogg file to a mp3 one, but that will probably require another module, and it could take some time converting it, so I choose to stick with mp3 extension (that doesn't make it a mp3 file! It's still a ogg file)"

To the people using pyspodl, if this affects your usage (keeps failing/erroring, etc) do the following:

1) Delete the entire set_metadata function (if you want, it's up to you) 2) Delete the line no. 366, 420, and 464 (or, comment these lines by adding a hashtag Infront of them)

devlocalhost commented 2 years ago

Another thing, I can't use my laptop for now, which means I'll have to test and write on my phone. This might take some time