devlocker / breakfast

Brunch.io with Rails
MIT License
96 stars 11 forks source link

Remove potential double yarn install #27

Closed PatKoperwas closed 6 years ago

PatKoperwas commented 6 years ago

Rails 5.1 ships with a bin/yarn command, which gets invoked during assets:precompile. Which means that in 5.1 yarn is being run twice (once by Rails, and once by Breakfast).

However, have to deal with the edge case of someone upgrading to 5.1 from 5.0 - in those cases they may not have generated the yarn binstub.

Got a little ahead of myself and went ahead and added a fallback definition for assets:precompile, in the case that someone is running Rails without sprockets.