search

devlom / grav-theme-hola

Hola is a modern and stylish vCard website template. Designed to be a resume, vCard, portfolio template, it’s the perfect template for creative designers, developers, freelancers, photographer or any creative profession. It is fully responsive and retina/hi-dpi ready. It will look great on any devices from desktop to mobile phones. It has blog page templates, working contact form, stylish portfolio section and other features you will only find on premium templates. Built with clean and organized code, this template is also very easy to customize.
MIT License
23 stars 7 forks source link

Portfolio module doesn't respect links #1

Closed qumuq-til closed 5 years ago

qumuq-til commented 5 years ago

In Portfolio module the links you specify in the "Link" field don't appear to be working. Clicking on portfolio images or the chain icon on top left only opens a preview of the image itself with the ability to navigate between images.

There should be an option for Portfolio items to either be direct links to other pages or just act as a gallery.

That way we can repurpose the module to be a simple showcase of work/images within a blog post, or a collection of images on the front page that act as direct links to blog posts talking about different projects.

Dzi0nek commented 5 years ago

Link is working now. Fix uploaded

qumuq-til commented 5 years ago

I've reuploaded the theme folder without changing anything else and apparently while the link circle now works properly (i.e. linking to some website) just clicking on the image simply opens that jpeg in the browser - no gallery mode.

I think the best way to handle that would be to have two mutually exclusive options for Portfolio modules: whether the images behave like links or whether they behave like a simple gallery without links.

The reason for that is that users may (and will!) find it hard and unintuitive to have to click on the "link" circle on the top left rather than the image itself, most will definitely miss that icon, and will be baffled by just the image loading.

It should either be a js gallery so a user can click away and see other images in that Portfolio or a set of links for which the images don't even open instead taking the visitor directly to another page.

qumuq-til commented 5 years ago

The issue is closed, but I don't think it should be, in its current condition.

For the moment the Portfolio is definitely half-baked. Not least because clicking on an image should really lead to a gallery, just like it was in your original iteration and like it is at Styleshout. The only thing needed fixing was the circular link at the top left.

hexplor commented 5 years ago

Mate.. This is really obvious for us and it's staying as is :) Styleshout has a bug in their html template. When you hover, it clearly shows external link in the code

https://monosnap.com/direct/t1LWomyQIoRQOVHrLGQCYqZpjqamMd

It's just not properly implemented and we fixed that in grav theme. I think it's logical explanation. You click on link -> points to external project page. You click on photo, it shows larger one.

qumuq-til commented 5 years ago

Actually when you click on an image in Styleshout's demo it doesn't take you directly to a bare image, it takes you to a gallery.