search

devlom / grav-theme-hola

Hola is a modern and stylish vCard website template. Designed to be a resume, vCard, portfolio template, it’s the perfect template for creative designers, developers, freelancers, photographer or any creative profession. It is fully responsive and retina/hi-dpi ready. It will look great on any devices from desktop to mobile phones. It has blog page templates, working contact form, stylish portfolio section and other features you will only find on premium templates. Built with clean and organized code, this template is also very easy to customize.
MIT License
23 stars 7 forks source link

Multiple issues with images placement in Blog #3

Open qumuq-til opened 5 years ago

qumuq-til commented 5 years ago
Dzi0nek commented 5 years ago

To be consistant with the design and the text around img's that are inserted will not be aligned to center because the text isn't. We will provide a fix for the img's to not ovelap each other.

qumuq-til commented 5 years ago

I beg to differ regarding the design, because you could say that landscape images in blog examples are indeed centered, page-wise. Leaving vertically aligned images stick to the left makes for a messy look that cannot be avoided. You can try that yourself and see if there's a better solution for vertical images. Maybe a selectable option to center them will be nice.

The images do get centered if the viewport is made a little narrower as seen in the examples above.

Dzi0nek commented 5 years ago

The only workaround for now is to use an image in html tags like this: <div class="align-center" markdown="1">![](tree.jpg)</div>

qumuq-til commented 5 years ago

Yep, that should work. You may also consider just stretching the vertical image in the theme to fill the entire horizontal space, i.e. making one huge vertical image.

Dzi0nek commented 5 years ago

We could but it usually makes page very long to scroll if couple of the image's are there and we would like to avoid that.

qumuq-til commented 5 years ago

Yes, that's true, I agree. But how about two stacked together? Take a look how it's done in Kalium. That approach does require identical ratios but works great.

kalium-two-column-image

Dzi0nek commented 5 years ago

Yes but this is different situation, we're talking about image grid collection inside blog post.

qumuq-til commented 5 years ago

Not sure I understand what you mean, but the screenshot did come from a blog page in Kalium. Edit: i.e. not the Portfolio module.

Dzi0nek commented 5 years ago

I mean you have to know before that you would like to do such image placement and provide specific classes for it. We did not changed styles that was provided by Styleshout.

qumuq-til commented 5 years ago

I see. With all due respect I think my reasoning is sound on this one. Design-wise something has to be done about vertical images so that they don't look out of place. Centering an image is one solution and making a grid with two stacked side by side is a good continuation of that. Just shifting a vertical image to the left completely breaks the elegance of the theme. Having users to provide all images in landscape orientation severely limits the theme's appeal.

Dzi0nek commented 5 years ago

I understand your point but at the moment we were not thinking about adding new features to the theme we only converted HTML theme to grav and if some functionality was missing in html version it will be missing in hola at the moment. Maybe in future we'll add new features.

qumuq-til commented 5 years ago

Sorry, my comment was misplaced.