search

devlooped / ThisAssembly

Exposes project and assembly level information as constants in the ThisAssembly class using source generators powered by Roslyn.
https://clarius.org/ThisAssembly
MIT License
430 stars 23 forks source link

Adopting SponsorLink in v2.0 #352

Open kzu opened 2 months ago

kzu commented 2 months ago

In order to improve the long-term sustainability of this (and other) projects, we'll be adopting SponsorLink v2.

Please get familiar with it, read the privacy statement and raise any doubts related to it in the SponsorLink repo itself.

All of SponsorLink is OSS too.

What this means for you:

  1. If you're not a sponsor (or you haven't synchronized your sponsorship), you will get a IDE-only warning reminding you that the project needs sponsorship.
  2. CLI or CI builds will never check for sponsorship.
  3. Sponsorship for ThisAssembly is no longer optional for in-IDE usage. (thanks @gumbarros for the convincing argument 😉, and also for being a valuable oss author who, along 35.3k others contributing to 2.3k repositories producing 4.6k packages, will never need to sponsor me to use my stuff, unless they want to 💜 ).

Back this issue Back this issue

gumbarros commented 4 weeks ago

Please remove the warning. Warnings are not meant for this, I would donate if this was not so agressive.

kzu commented 4 weeks ago

Why do you consider a warning to be agressive?

Informational messages are typically not even read, are they? In addition, the warning never causes a build error, so it's just to keep it visible, and it only shows up in the IDE.

Would you mind sharing how many informational messages you have in the same solution where you got the warning? 🙏

gumbarros commented 4 weeks ago

Would you mind sharing how many informational messages you have in the same solution where you got the warning? 🙏 image

None, just the ThisAssembly warning. We have a "no-warning" policy in our project and this is mildy-infuring

gumbarros commented 4 weeks ago

For anyone wanting to disable this message:

<PropertyGroup>
    <NoWarn>TA101</NoWarn>
</PropertyGroup>
kzu commented 4 weeks ago

Run dotnet build from a regular terminal, or CI, and you'll see there are no warnings in those cases. I'm explicitly accounting for "no warnings" policies so it should never cause a biuld error.

That said, would you have noted the message if had been an Info rather than a Warning? Genuinely curious 🙏

gumbarros commented 4 weeks ago

Run dotnet build from a regular terminal, or CI, and you'll see there are no warnings in those cases. I'm explicitly accounting for "no warnings" policies so it should never cause a biuld error.

That said, would you have noted the message if had been an Info rather than a Warning? Genuinely curious 🙏

At Rider IDE it's very infuring, when I have a warning I get this popup everytime.

image

kzu commented 4 weeks ago

Ah. That's an annoying IDE "feature" 🤔 . I don't have a Rider license and my trial expired LOOONG ago.

Does it make it slightly less infuriating to know you can support the project and get rid of the warning for just $1-$2 say?

Another question: does that annoying popup show up only because you have the warnings as errors setting or is this a regular thing for Rider? (like for any project regardless of any MSBuild settings)

kzu commented 1 day ago

Thanks to the new implicit oss I implemented, @gumbarros and the other 35.3k valuable oss authors contributing to 2.3k repositories producing 4.6k packages, will never need to sponsor me to use my stuff (unless they want to).

See https://www.devlooped.com/SponsorLink/github/oss/?a=gumbarros

image