search

devmark / angular-slick-carousel

Angular directive for slick-carousel
http://devmark.github.io/angular-slick-carousel/
MIT License
353 stars 125 forks source link

jQuery Version >3 #133

Open helgetan opened 7 years ago

helgetan commented 7 years ago

If using lazy-load i get the following error:

TypeError: url.indexOf is not a function
    at jQuery.fn.init.jQuery.fn.load (http://localhost:8080/bower_components/jquery/dist/jquery.js:9823:13)
    at HTMLImageElement.<anonymous> (http://localhost:8080/bower_components/slick-carousel/slick/slick.min.js:18:17138)
    at Function.each (http://localhost:8080/bower_components/jquery/dist/jquery.js:362:19)
    at jQuery.fn.init.each (http://localhost:8080/bower_components/jquery/dist/jquery.js:157:17)
    at g (http://localhost:8080/bower_components/slick-carousel/slick/slick.min.js:18:17078)
    at c.b.lazyLoad (http://localhost:8080/bower_components/slick-carousel/slick/slick.min.js:18:17723)
    at c.b.setSlideClasses (http://localhost:8080/bower_components/slick-carousel/slick/slick.min.js:18:25107)
    at c.b.buildOut (http://localhost:8080/bower_components/slick-carousel/slick/slick.min.js:18:7511)
    at c.b.init (http://localhost:8080/bower_components/slick-carousel/slick/slick.min.js:18:14335)
    at new c (http://localhost:8080/bower_components/slick-carousel/slick/slick.min.js:18:3040) undefined
(anonymous) @ angular.js:14199

The problem is caused by the deprected .load usage: see: https://stackoverflow.com/questions/37738732/jquery-3-0-url-indexof-error

Maybe someone has time to fix this:

Update all code that calls load function like,

$(window).load(function() { ... }); To

$(window).on('load', function() { ... });