devmark / angular-slick-carousel

Angular directive for slick-carousel
http://devmark.github.io/angular-slick-carousel/
MIT License
353 stars 125 forks source link

LazyLoaded event never fired #81

Closed artuska closed 8 years ago

artuska commented 8 years ago

This is my Slick config:

var carouselConfig = {
    infinite: true,
    draggable: false,
    slidesToShow: 1,
    slidesToScroll: 1,
    initialSlide: 0,
    lazyLoad: 'ondemand',
    event: {
        afterChange: function (event, slick, currentSlide, nextSlide) {
            console.log(event, slick, currentSlide, nextSlide);
        },
        beforeChange: function (event, slick, currentSlide, nextSlide) {
            console.log(event, slick, currentSlide, nextSlide);
        },
        lazyLoaded: function (e, slick, img, src) {
            console.log(e, slick, img, src);
        }
    }
};

afterChange and beforeChange events are fired, lazyLoaded event never fired.

Vangor commented 8 years ago

@devmark looks like there is just no method for that, do you have a plan to implement that? :) If not, I've made pull-request for that bug. Please check it

devmark commented 8 years ago

should be work on version 3.1.6

Vangor commented 8 years ago

Yeap, thank you!

On Fri, Jul 22, 2016 at 4:49 PM Mark notifications@github.com wrote:

should be work on version 3.1.6

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/devmark/angular-slick-carousel/issues/81#issuecomment-234548611, or mute the thread https://github.com/notifications/unsubscribe-auth/ADlRzjGGNoz5rqC_N2I3nTJyREi4mJ2mks5qYMpQgaJpZM4JA8Yq .

Vangor commented 8 years ago

In last version from bower there is console output in file angular-slick.js:266 console.log('=lazyLoadedlazyLoadedlazyLoaded') Is it possible to delete it?)

devmark commented 8 years ago

Thanks for report . will del soon