search

devmasx / merge-branch

A GitHub Action that merge PR branch to other branchs
163 stars 57 forks source link

Updates `from_branch` to `head_to_merge` #8

Closed brucebrophy closed 4 years ago

brucebrophy commented 4 years ago

Hey, thanks for the great action! I tried it out and it looks like the current readme examples do not work.

I've updated the readme so that other devs can copy the examples and get a successful workflow. (see issue #6 )

Let me know if this is a side-effect of another issue.

MiguelSavignano commented 4 years ago

Hello @brucebrophy head_to_merge and from_branch they should be aliases. It is necessary to set as default the name of the branch that triggered the event.

The main problem it is necessary to check if the values are empty strings

@head_to_merge = ENV['INPUT_HEAD_TO_MERGE'] || ENV['INPUT_FROM_BRANCH'] || ENV['GITHUB_SHA'] # or brach name
MiguelSavignano commented 4 years ago

Now we can use from_branch or head_to_merge in v1.3.1 version