search

devmentors / DNC-DShop.Services.Identity

MIT License
27 stars 35 forks source link

Introducing Jaeger broke the Identity Service and prevents the customer from signing up #5

Open bravecobra opened 5 years ago

bravecobra commented 5 years ago

After introducing Jaeger, the call POST {{identityServiceUrl}}/sign-up broke. Or any API call for that matter that is being passed an empty CorrelationContext. The empty Correlation context is being handled properly in the API gateway, but calls to the IdentityService do no pass the API gateway and in the IdentityService an empty CorrelationContext is not handled properly (and it does not contain a SpanContext that can be send to Jaeger). It throws an exception in the Jaeger middleware.

To fix this, the IdentityService needs to handle empty CorrelationContext's properly. We could borrow the methods from BaseController of the API gateway. Then, the event, sent from the IdentityService class, also needs that new properly handled CorrelationContext, in order to pass it on when publishing the event.

GooRiOn commented 5 years ago

Hi, thx for the comment! We actually noticed that recently. Therefore some fix will be published soon (possibly tommorow).