search

devmil / muzei-bingimageoftheday

Bing Image of the Day plugin for Muzei
Apache License 2.0
22 stars 4 forks source link

Selectable quality #13

Open alexanderadam opened 3 years ago

alexanderadam commented 3 years ago

Other plugins and extensions allow to select the wallpaper resolution.

It would be great if this could be a setting for this image provider as well.

Thank you for your work! :pray:

alexanderadam commented 3 years ago

Otherwise maybe just switching to high resolution would be sufficient, too? Or would it have any disadvantage? Android will probably scale down anyway, once it's using an image with a higher resolution than the device can show, right? :thinking:

devmil commented 3 years ago

Hi, thanks for your input. I think retrieving the highest possible resolution would be totally OK.

The problem is: I can't find a reference to the portrait variant of the UHD image. The lower resolutions use width and hight in the URL and when those are exchanged then you get an optimized portrait image (where the focus is set correctly). This is what this add-on uses.

For UHD the URL format changed to not contain the width and hight but "UHD" which returns the landscape variant.

alexanderadam commented 3 years ago

I see. Would it be possible to use the legacy URL for portrait and UHD for landscape?

alexanderadam commented 3 years ago

Is there anything I could help with (except from programming Kotlin)?

devmil commented 3 years ago

I just released a new version into the testing stage (open testing) that uses UHD for landscape images. Edit: this is currently in review so might take a while to show up as an update

devmil commented 3 years ago

Please let me know when you were able to try this version so that I can do the official release and close this issue

alexanderadam commented 3 years ago

I just released a new version into the testing stage (open testing) that uses UHD for landscape images. Edit: this is currently in review so might take a while to show up as an update

I was wondering why I still didn't get any update until I recognized that I installed the F-Droid release and you were probably referring to the Beta program of Google Play, right? I will try this later.

alexanderadam commented 3 years ago

Please let me know when you were able to try this version so that I can do the official release and close this issue

It's working perfectly. Incredible how crisp the image quality is in comparison. Thank you so much! :pray:

Will you close this issue by yourself after you released this change?