search

devmil / muzei-bingimageoftheday

Bing Image of the Day plugin for Muzei
Apache License 2.0
22 stars 4 forks source link

Incompatible API use in your codes. #3

Open jay2013 opened 6 years ago

jay2013 commented 6 years ago

Hi, We notice that you use com.android.volley as an external library. this library use API like "<org.apache.http.HttpEntity: java.io.InputStream getContent()>", "<org.apache.http.impl.cookie.DateUtils: java.lang.String formatDate(java.util.Date)>" that are already removed after SDK level 23. These API use are very likely to cause crash to your app because the minSDKVersion of your APP is 17.

There are exist reachable path from your code to these api. For example, the reachable path to the first API we mentioned above is: <de.devmil.muzei.bingimageoftheday.BingImageOfTheDayArtSource: void onTryUpdate(int)> --><de.devmil.muzei.bingimageoftheday.cache.BingImageCache: void ensureMissingImages()> --><de.devmil.muzei.bingimageoftheday.cache.ImageDownloader: void download(java.util.List)> --><de.devmil.muzei.bingimageoftheday.cache.ImageDownloader: void processNextQueueItem()> --><de.devmil.muzei.bingimageoftheday.cache.ImageDownloadRequest: void download(android.content.Context,android.net.Uri)> --><com.android.volley.toolbox.Volley: com.android.volley.RequestQueue newRequestQueue(android.content.Context)> --><com.android.volley.toolbox.Volley: com.android.volley.RequestQueue newRequestQueue(android.content.Context,com.android.volley.toolbox.HttpStack)> --><com.android.volley.RequestQueue: void start()> --><com.android.volley.NetworkDispatcher: void run()> --><com.android.volley.toolbox.BasicNetwork: com.android.volley.NetworkResponse performRequest(com.android.volley.Request)> --><com.android.volley.toolbox.BasicNetwork: byte[] entityToBytes(org.apache.http.HttpEntity)> --><org.apache.http.HttpEntity: java.io.InputStream getContent()>

We use android studio to analyze your app's apk file, and we also find methods in org.apache.http.HttpEntity don't have definition, they are all referenced methods which need android platform to support. selection_002

more bugs, please refer to this file below. de.devmil.muzei.bingimageofthedayartsource_5.apk.txt

We cannot make 100% sure about the reachable path, so we need your help to check whether it is reachable from your code to these unsupported API. Thanks very much.

best regards,

Dongjie He