search

devnacho / mountain_view

Living styleguide for Rails
MIT License
273 stars 29 forks source link

Allowing override of the styleguide_path #46

Closed MikeRogers0 closed 7 years ago

MikeRogers0 commented 7 years ago

This'll allows end users to userride the path used by the MountainView::Engine.routes

MikeRogers0 commented 7 years ago

I need to make some changes for hound before this is ready for merge, also any direction in how you'd like this tested? I added a TDD test, but I think something closer to an integration would serve it better.

kitop commented 7 years ago

@MikeRogers0 Thanks a lot for the PR! Looks really good!

As you said, it would be really nice to have an integration test when setting the styleguide_path to something different. You already added one for the default case (🎉 ), and would be great to have another one for a custom path.

Thanks again! Really appreciate your great work!

MikeRogers0 commented 7 years ago

would be great to have another one for a custom path.

@kitop BAM

kitop commented 7 years ago

@MikeRogers0 Amazing!!! And thanks so much for the contribution!!

Merging this and releasing a new version :)