Closed robsdedude closed 4 years ago
You might notice that, in contrast to what I wrote in my comment, you can see the list items load now. This is a recent change I made that makes the scrolling smoother. If you prefer the previous behavior (i.e. lagging scrolling but no missing list items) try setting MAX_LOAD_LIST_ITEMS_PER_CYCLE
to something like 7 I guess.
Have you tried it out with increased heap size already?
Sorry for the late reply I thought that I had replied already. Yes I tried it and it didn't solve the issue. I've also tried to increase stack size without luck.
I have no idea why your fix works, but it's great that it does!
This fixes #75 but it makes the search more fragile.
Feel free to play around with
PRE_RENDER_EXTRA_LIST_ITEM
andMAX_LOAD_LIST_ITEMS_PER_CYCLE
insrc/Views/ListView/listView.h
. They will modify the smoothness of scrolling and the memory footprint.Now about the search. Things I found out:
src/Views/ListView/searchView.cpp
lines 34-43 (which as expected makes the search do nothing but always show all homebrews) seems to fix the crashing.Thus, I assume it is a memory leak or so, but I couldn't find a way to fix it. Sorry, I'm still not a c/c++ developer :man_shrugging:. Maybe you could have a look and find what's wrong.
PS: I marked it as WIP because of the search issue. Feel free to merge it anyway, if you want a hotfix. I won't continue the bug hunt until I have new input on this.