devnums / pyheartlib

A Python package for processing electrocardiogram signals ❤️
https://pyheartlib.readthedocs.io/
GNU Affero General Public License v3.0
2 stars 1 forks source link

add comparison with other libraries for peak detection #10

Closed LegrandNico closed 11 months ago

LegrandNico commented 1 year ago

As the added value of the package is to facilitate the use of machine learning and deep learning methods to analyse ECG signal, it would be useful to see how this relate to other methods, especially methods that are simpler. I would suggest a comparison with the peak detection algorithms provided by Neurokit2 and SleepECG.

This issue is related to the review of the package for JOSS (see here).

devnums commented 1 year ago

Thank you for your suggestion. I have edited the paper, please take a look at it here and let me know if that's what you mean.