devnums / pyheartlib

A Python package for processing electrocardiogram signals ❤️
https://pyheartlib.readthedocs.io/
GNU Affero General Public License v3.0
2 stars 1 forks source link

Test model on separate dataset #17

Open Bsingstad opened 10 months ago

Bsingstad commented 10 months ago

As far as I can see you are training, testing and validating your model on the same dataset; MIT BIH Arrhythmia Database. To validate that this model also works on other datasets (possibly using other hardware, measurement set up and so on) would be a huge strange for this software package in my opinion.

devnums commented 9 months ago

This software can be used with other datasets and different machine learning models. It is only required that the datasets have a similar format and structure to the MIT-BIH Arrhythmia Database.

Bsingstad commented 9 months ago

Ok, then it would be nice of you to show this in the paper. From what you have showed we can't know if the model is overfitted to the specific dataset (MIT-BIH Arrhythmia Database).