search

devoidfury / express-debug

Debug toolbar middleware for developing applications in express (node.js)
Other
199 stars 16 forks source link

Express 4.x support #11

Open uiii opened 10 years ago

uiii commented 10 years ago

Hi, it would be great to support Express 4.x.

devoidfury commented 10 years ago

Thanks for the report!

This weekend I'll check to see if any forks have started on 4.x support, and if not, I'll knock it out.

devoidfury commented 10 years ago

Basic support for 4.x included in the latest release (1.1.0), with everything but the profile panel.

Let me know if you have any feedback!

Offirmo commented 10 years ago

Hello, this looks nice. I'm trying with express 4. Could you update the documentation ? 

app.configure('development', function() {
    ^
TypeError: Object function (req, res, next) {
    app.handle(req, res, next);
  } has no method 'configure'
devoidfury commented 10 years ago

Good call, thanks. It's updated on the master version readme.

Offirmo commented 10 years ago

And it works ! Express 4.2 latest. At /express-debug only, though.

My application serves an index.html (via express.static). Care to explain the conditions for the debug tab integration ?

devoidfury commented 10 years ago

The tab will only show when render is called in a route, usually when using a template engine. There isn't a clean way to inject into express.static served files, as far as I'm aware.

Offirmo commented 10 years ago

Ok. I haven't been able to make my dust render work yet.

Express 4.2 validation : OK from me.

Thanks !

Offirmo commented 10 years ago

As a note : everything is fine now, EDT gest integrated in my template pages.

Maybe we could close this issue ?