search

devoidfury / express-debug

Debug toolbar middleware for developing applications in express (node.js)
Other
199 stars 16 forks source link

add configurable depth and sort #14

Closed vaughan99 closed 10 years ago

vaughan99 commented 10 years ago

Only implemented boolean for sort, not function. Still, very worth it to me and my developers for what we need.

devoidfury commented 10 years ago

Thanks! I'll check this out tonight and release a new version (with some other fixes that have been pending).

vaughan99 commented 10 years ago

Cool, thx.  The impetus for this was that we made our own panel for Kraken config (work for PayPal, progenitor of krakenjs).  We really needed an eventual functional sort.  That being said, I will submit another PR for 'sort' being a function too... no ETA on that.  We need to sort middleware by priority in the Kraken config.

Thanks, Chris

 

From: Thomas Hunkapiller notifications@github.com To: devoidfury/express-debug express-debug@noreply.github.com Cc: vaughan99 vaughan99@yahoo.com Sent: Thursday, August 14, 2014 11:33 AM Subject: Re: [express-debug] add configurable depth and sort (#14)

Thanks! I'll check this out tonight and release a new version (with some other fixes that have been pending). — Reply to this email directly or view it on GitHub.

devoidfury commented 10 years ago

I went ahead and added the sort function option, it was a pretty quick change. New version is published, let me know if you have any issues.

devoidfury commented 10 years ago

I might take a look over the weekend into a more advanced sort that gives access to the values for sorting the keys, too. That would probably be more useful ;-)