search

devoidfury / express-debug

Debug toolbar middleware for developing applications in express (node.js)
Other
199 stars 16 forks source link

add windows paths support #22

Open bonesoul opened 9 years ago

bonesoul commented 9 years ago

doesnt work on windows!

path.js:8                                                                                                      
    throw new TypeError('Path must be a string. Received ' +                                                   
    ^                                                                                                          

  TypeError: Path must be a string. Received [ 'E:\\Coding\\hypetrain\\src\\views'                             
   ]                                                                                                           

  - path.js:8 assertPath                                                                                       
    path.js:8:11                                                                                               

  - path.js:221 Object.win32.join                                                                              
    path.js:221:5                                                                                              

  - index.js:12 getPath                                                                                        
    [hypetrain]/[express-debug]/lib/panels/template/index.js:12:21                                             

  - index.js:29 Object.module.exports.process                                                                  
    [hypetrain]/[express-debug]/lib/panels/template/index.js:29:34                                             

  - index.js:85 Object.panels.render                                                                           
    [hypetrain]/[express-debug]/lib/panels/index.js:85:32                                                      

  - response.js:70 render_toolbar                                                                              
    [hypetrain]/[express-debug]/lib/response.js:70:37
devoidfury commented 9 years ago

It looks like it was expecting a string and got an array. Thanks for the report, will fix!

bonesoul commented 8 years ago

hopefully when? :)

bonesoul commented 8 years ago

any updates on this?

devoidfury commented 8 years ago

I haven't had time to do active maintenance lately. If you'd like to submit a PR I'd be happy to pull it in and push a new version!