search

devolo / cockpit_open_frontend

A rewrite of the devolo Cockpit front end in Flutter
BSD 3-Clause "New" or "Revised" License
6 stars 3 forks source link

Add GitHub workflow #8

Closed olof-nord closed 2 years ago

olof-nord commented 2 years ago

Looking at the repo, as there is a gitlab CI file, I am guessing somewhere a pipeline is executed.

As to also automatically test GitHub pull requests, one idea would be to add a GitHub Workflow which does the same as the GitLab CI.

This PR is implementing a GitHub Workflow which does roughly the same as the GitLab CI automation.

Shutgun commented 2 years ago

Hi @olof-nord , it looks like the tests are executed twice. Same in the gitlab CI by the way. Do you see a chance to combine both flutter test calls?

olof-nord commented 2 years ago

Hello @Shutgun, very good question.

I do not have much experience with flutter, but it seems that the two test commands differ slightly, the second one is testing the lib part of the application, the first one the whole project.

Feel free to use this branch as a starting point for further exploration/research.

julienAhn commented 2 years ago

Hey @olof-nord @Shutgun, both test calls are executing all created unit-tests in our project. I think the reason why we seperated them is that both arguments "--machine" and "--coverage" didn´t worked together. As we don´t really need a json output file I´m fine to not use the "--machine" argument and to have only one test call. I will merge #9 and close this one.