Got same package, maybe we could merge it together?)

devonestes / assertions

Helpful assertions for ExUnit

MIT License

143 stars 29 forks source link

Got same package, maybe we could merge it together?) #2

Closed Apelsinka223 closed 3 years ago

Apelsinka223 commented 5 years ago

Hi! Thank for the package, I guess same problems disturbs many of Elixir programmers :) I got same package here https://github.com/Apelsinka223/test_match, and I'm pretty new to open source and I'm not sure how it is usually works, but I think it would be great to merge features of our packages in one, so it would become more handy and maybe become a common pattern to use :) Thank you anyway, I would be glad to receive any response!

devonestes commented 5 years ago

Howdy @Apelsinka223!

It looks to me like assertions implements a superset of what's in test_match - is that right? Is there any behavior that's in test_match that isn't in assertions at the moment? I'd be happy to add that behavior in if there's something you think is missing! PRs are also warmly welcomed if you want to send one along.

Ninigi commented 5 years ago

@Apelsinka223 there is nothing inherently bad about having 2 different solutions to solve the same problem. Maybe some people will prefer having a more bare-bone, closer to the metal package and implement everything else themselves.