search

devonestes / assertions

Helpful assertions for ExUnit
MIT License
142 stars 29 forks source link

Temporarily remove compilation check for Absinthe #24

Open timgremore opened 3 years ago

timgremore commented 3 years ago

Assertions conditionally adds helpers for use with Absinthe. Assertions.Absinthe utilizes Code.ensure_compiled/1 to manage this condition. However, undefined function assert_response_equals/4 is raised when compiling all dependencies. Recompiling assertions after compiling all dependencies satisfies the call to Code.ensure_compiled/1 and the exception is avoided. This removes the conditional check until a proper solution can be found and since we are using Absinthe.

Issue is also described https://github.com/devonestes/assertions/issues/22

thelastinuit commented 3 years ago

@timgremore you saved me from hell... I've been drying myself nuts around this issue until I came up with your comments. I know this is for issues only but I wanted it to thank you.

allenwyma commented 2 years ago

hi @devonestes can we get this merged in soon? Did you need some help with that?

btkostner commented 1 week ago

Heads up, this is still an issue and would be really nice to get merged in.