search

devonfw-forge / mrchecker-source

Mr.Checker E2E source files
Apache License 2.0
16 stars 4 forks source link

188_workaround for test cases to run without session exception #16

Closed MalgorzataDzienia closed 5 years ago

MalgorzataDzienia commented 5 years ago
  1. Sesion exception BROWSER_TIMEOUT is fixed by using in selenium tests the right structure of test case which inherit BaseTest and test page which inherit BasePage.
  2. There is no need to close driver in the test case, because it is done automatically in framework.
  3. This is quick fix, the refactoring of test cases is planned to be done with review tasks which are assigned to @MajPat .
CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

tompalka commented 5 years ago

@przwojtkow @pawel-szczesny @lstefaniszyn Please take a look and merge it if you find everything ok

MalgorzataDzienia commented 5 years ago

This is a little confusing that just adding not used page object as member in the test fixes SessionTimeout issue. But as we're planning to refactor this code and marked class to be removed after refactor, it is temporary solution. Just to be sure - please add to QuickFixSeleniumPage comments which issue is going to remove this class.

There is a comment in QuickFixSeleniumPage See the file:

public class QuickFixSeleniumPage extends BasePage { //This page is created to fix Selenium Session Exception from tes.WebElements test cases. //When the test cases are refactored, this page should be deleted.

tompalka commented 5 years ago

This is a little confusing that just adding not used page object as member in the test fixes SessionTimeout issue. But as we're planning to refactor this code and marked class to be removed after refactor, it is temporary solution. Just to be sure - please add to QuickFixSeleniumPage comments which issue is going to remove this class.

There is a comment in QuickFixSeleniumPage See the file:

public class QuickFixSeleniumPage extends BasePage { //This page is created to fix Selenium Session Exception from tes.WebElements test cases. //When the test cases are refactored, this page should be deleted.

I meant to add issue number in the comment. I saw that there is a comment which actually explains a lot.

MalgorzataDzienia commented 5 years ago

I'm approving but I agree that it should be refactored. @MalgorzataDzienia Can you provide link to created task for refactor? After that please merge this PR.

Issue created https://github.com/devonfw-forge/mrchecker-source/issues/18