search

devonfw / cobigen

Code-based Incremental Generator
Apache License 2.0
35 stars 70 forks source link

Restore DAO template support #1555

Closed maybeec closed 2 years ago

maybeec commented 2 years ago

As a architect, I want to be able ton continue using DAO approach so that I can continue working with DAOs instead of Spring Repositories.

Therefore, we should restore the deleted DAO templates now as a separate package within our modular configuration.

Requesting Discussion: #1549

Acceptance Criteria:

`Further Reading https://devonfw.com/website/pages/docs/devonfw-guide_devon4j.wiki_guide-jpa.asciidoc.html#devonfw-guide_devon4j.wiki_guide-repository.asciidoc

maybeec commented 2 years ago

Hey team! Please add your planning poker estimate with ZenHub @Ali7223 @EduardKrieger @jan-vcapgemini @mdukhan @ZakariaeMkassi @Zylesto @quantumfate @morsymegahed

maybeec commented 2 years ago

Please add your planning poker estimate with ZenHub @NelsonNew

Zylesto commented 2 years ago

I have done a little bit of research on the topic. The commit with the following hash is the last one containing dao: 8ec69f8d7ba7eb154532481db2633dd0f197b271. Here you can see the removal history: https://github.com/devonfw/cobigen/commits/master?before=46bb19406003198ab2ad50db6a9ad2120c21b9e4+315&branch=master&path%5B%5D=cobigen-templates&qualified_name=refs%2Fheads%2Fmaster

jan-vcapgemini commented 2 years ago

It appears that this issue can be closed.

After recovering the old DAO template, it became obvious that the outdated way of handling PaginatedListTo using io.oasp does not suffice.

We can now either rewrite a completely new Paginator or remove the support for DAO and keep using springframework repositories instead.

I'd recommend to check if DAO is still being used in projects and if not, to close this issue.

maybeec commented 2 years ago

Closing it. If there is any interest please reopen