search

devonfw / dashboard

devonfw dashboard
Apache License 2.0
5 stars 17 forks source link

Unable to finish devonfw-ide installation #77

Open jambulud opened 4 years ago

jambulud commented 4 years ago

Describe the bug When the installation of a new devonfw-ide version finishes, the cancel button does not change to finished

To Reproduce Steps to reproduce the behavior:

  1. Go to devonfw dashboard folder
  2. Open a terminal an start devonfw dashboard.
  3. Click on install latest version
  4. Complete the installation process with default data
  5. See in the installation terminal the message Completed, but the button is still on Cancel

Expected behavior When the installation terminal displays Completed, the button Cancel should transform to Close.

Desktop (please complete the following information):

Additional context In Windows, when the terminal shows Press any key to continue, it sends a finished status to the front-end side. If this message is omitted in linux, then it won't send finished

suprishi commented 4 years ago

So should there be an issue raised in ide for adding a terminating message in linux/mac on successful installation or should it be handled in dashboard only?

Also, for Windows, is this the best way to determine finished status since it is tightly coupled with the terminating message? If for whatsoever reasons the message is changed or discarded in the future, it would have to be handled in the dashboard.