search

devonfw / devon4j

devonfw Java stack - create enterprise-grade business apps in Java safe and fast
Apache License 2.0
83 stars 87 forks source link

Feature/liquibase configuration #340

Open dixyushi opened 3 years ago

dixyushi commented 3 years ago

I have resolved the issue(i.e. Consider liquibase #303). In that I have changed the configuration of flyway into liquibase.

hohwille commented 3 years ago

FYI: I typically do not start reviews before PRs are up-to-date with master and CI is succeeding. I guess you have seen already in travis logs that we have integrated deeper with flyway so you need to add some switches there:

[INFO] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project app-with-batch-batch: Compilation failure: Compilation failure: 

[INFO] [ERROR] /home/travis/build/devonfw/devon4j/templates/server/target/test-classes/projects/batch/project/app-with-batch/batch/src/test/java/it/pkg/general/batch/base/test/SpringBatchIntegrationTest.java:[5,25] package org.flywaydb.core does not exist

[INFO] [ERROR] /home/travis/build/devonfw/devon4j/templates/server/target/test-classes/projects/batch/project/app-with-batch/batch/src/test/java/it/pkg/general/batch/base/test/SpringBatchIntegrationTest.java:[24,11] cannot find symbol

[INFO] [ERROR]   symbol:   class Flyway

[INFO] [ERROR]   location: class it.pkg.general.batch.base.test.SpringBatchIntegrationTest

So please fix CI and merge master with your feature-branch (there are conflicts, otherwise I would have done it for you here on github UI)...

hohwille commented 3 years ago

@dixyushi can you fix the merge conflicts and bring this PR to a "ready for review" state?

hohwille commented 3 years ago

FYI: https://forum.liquibase.org/t/create-spring-boot-starter/5577

hohwille commented 2 years ago

This issue seems state. How should we proceed here?