devonfw / devon4j

devonfw Java stack - create enterprise-grade business apps in Java safe and fast
Apache License 2.0
83 stars 87 forks source link

devon4j-logging depends on httpclient #438

Closed hohwille closed 2 years ago

hohwille commented 3 years ago

I just accidentally stumbled over the fact that devon4j-logging depends on httpclient: https://github.com/devonfw/devon4j/blob/master/modules/logging/pom.xml#L51

IMHO this is a bug and that exists from day 1 of devon4j. However, it did not exist in oasp4j-logging: https://github.com/oasp/oasp4j/blob/develop/modules/logging/pom.xml

So IMHO an unintendet bug that happened when oasp4j was "copied" to create devon4j. This dependency should simply be removed as it is missplaced.

ssarmokadam commented 3 years ago

@hohwille Ayushi removed this dependency and raised PR https://github.com/devonfw/devon4j/pull/440 but build is failing. We are using this in PerformanceLogger class. In oasp4j also we have this dependency at https://github.com/oasp/oasp4j/blob/4ff7e9eb9900455befc40e1375efb64005205de9/modules/logging/pom.xml#L47

hohwille commented 3 years ago

Remove the dependency to HttpStatus:

For the last one simply hardcode 500.

hohwille commented 2 years ago

PR #440 has been merged almost a year ago. Hence closing this issue.