#97: Make architecture configurable

devonfw / sonar-devon4j-plugin

Plugin for SonarQube to validate devonfw architecture

Apache License 2.0

10 stars 16 forks source link

#97: Make architecture configurable #112

Closed lmarniazman closed 3 years ago

lmarniazman commented 3 years ago

Fix for #97

This is still WIP
References to Devon4jPackage were refactored to DevonArchitecturePackage
Reimplementation of methods will be added

lmarniazman commented 3 years ago

Most of the tests are still failing because of a NPE inside DevonArchitectureCheck.getFileToScan()

lmarniazman commented 3 years ago

NPE could be resolved, now an IllegalStateException makes the test fail. It seems that the packageName of the test files is not resolved properly.

hohwille commented 3 years ago

@lmarniazman we are on the edge of the release and this is the major feature for it. I have no idea what these exceptions have to do with the actual story. We have a fully qualified type name and want to analyze things like component, layer, scope, etc. Before the regex for the analysis was hardcoded and now it is configurable. How is that related? Shall we have an urgent call to clarify and hopefully resolve this problem? Otherwise I have to drop this feature from the release what would be rather sad...

hohwille commented 3 years ago

I merged this PR locally and also fixed several small bugs (not from this PR but already in the code before) and added missing JavaDoc. Also I did quite some refactoring to improve the codebase. As I squashed the merge commit, the PR did not get marked as merged even though it is. I will simply close it as all is done.